Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_rotation_period of Linkage does not work for negative angle cranks #7

Closed
HugoFara opened this issue Jun 18, 2023 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@HugoFara
Copy link
Owner

Using an crank with a negative rotation would prevent this method to work. freq = round(tau / j.angle) should be replaced by freq = round(tau / abs(j.angle)).

For now users can defined and angle above pi to solve this issue (instead of using an angle of -0.1, use 2*pi-0.1).

@HugoFara HugoFara added the bug Something isn't working label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant