From 5a387899f11006fd0711133dbbb2b0e6ef3621c9 Mon Sep 17 00:00:00 2001 From: Martin Strecker Date: Thu, 4 May 2017 09:46:50 +0200 Subject: [PATCH] Incorporated review comments by @khellang, @M-Zuber, @jeremymeng. Marked reviewed language with "Native speaker". Marked 'sv' as reviewed even confirmation is pending. --- .../Localisation/da/TimeSpanHumanizeTests.cs | 6 +++--- .../Localisation/he/TimeSpanHumanizeTests.cs | 10 +++++----- .../Localisation/nb/TimeSpanHumanizeTests.cs | 4 ++-- .../Localisation/sv/TimeSpanHumanizeTests.cs | 8 ++++---- .../Localisation/zh-CN/TimeSpanHumanizeTests.cs | 4 ++-- .../Localisation/zh-Hans/TimeSpanHumanizeTests.cs | 4 ++-- .../Localisation/zh-Hant/TimeSpanHumanizeTests.cs | 4 ++-- src/Humanizer/Properties/Resources.da.resx | 2 +- src/Humanizer/Properties/Resources.he.resx | 6 +++--- src/Humanizer/Properties/Resources.sv.resx | 4 ++-- src/Humanizer/TimeSpanHumanizeExtensions.cs | 2 +- 11 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/Humanizer.Tests.Shared/Localisation/da/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/da/TimeSpanHumanizeTests.cs index d11c84836..2ea633eda 100644 --- a/src/Humanizer.Tests.Shared/Localisation/da/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/da/TimeSpanHumanizeTests.cs @@ -8,8 +8,8 @@ public class TimeSpanHumanizeTests { [Theory] - [Trait("Translation", "Google")] - [InlineData(366, "en år")] + [Trait("Translation", "Native speaker")] + [InlineData(366, "et år")] [InlineData(731, "2 år")] [InlineData(1096, "3 år")] [InlineData(4018, "11 år")] @@ -19,7 +19,7 @@ public void Years(int days, string expected) } [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(31, "en måned")] [InlineData(61, "2 måneder")] [InlineData(92, "3 måneder")] diff --git a/src/Humanizer.Tests.Shared/Localisation/he/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/he/TimeSpanHumanizeTests.cs index 2d7158e4e..f1750fef2 100644 --- a/src/Humanizer.Tests.Shared/Localisation/he/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/he/TimeSpanHumanizeTests.cs @@ -8,9 +8,9 @@ public class TimeSpanHumanizeTests { [Theory] - [Trait("Translation", "Google")] - [InlineData(366, "שנה אחת")] - [InlineData(731, "שנים")] + [Trait("Translation", "Native speaker")] + [InlineData(366, "שנה")] + [InlineData(731, "שנתיים")] [InlineData(1096, "3 שנים")] [InlineData(4018, "11 שנים")] public void Years(int days, string expected) @@ -19,9 +19,9 @@ public void Years(int days, string expected) } [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(31, "חודש")] - [InlineData(61, "חודשים")] + [InlineData(61, "חודשיים")] [InlineData(92, "3 חודשים")] [InlineData(335, "11 חודשים")] public void Months(int days, string expected) diff --git a/src/Humanizer.Tests.Shared/Localisation/nb/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/nb/TimeSpanHumanizeTests.cs index b970c5460..f0c3ba0b5 100644 --- a/src/Humanizer.Tests.Shared/Localisation/nb/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/nb/TimeSpanHumanizeTests.cs @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests { [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(366, "ett år")] [InlineData(731, "2 år")] [InlineData(1096, "3 år")] @@ -20,7 +20,7 @@ public void Years(int days, string expected) [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(31, "en måned")] [InlineData(61, "2 måneder")] [InlineData(92, "3 måneder")] diff --git a/src/Humanizer.Tests.Shared/Localisation/sv/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/sv/TimeSpanHumanizeTests.cs index bf8e72c2b..da70eab51 100644 --- a/src/Humanizer.Tests.Shared/Localisation/sv/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/sv/TimeSpanHumanizeTests.cs @@ -57,8 +57,8 @@ public void Weeks(int number, string expected) [Theory] - [Trait("Translation", "Google")] - [InlineData(31, "1 månad")] + [Trait("Translation", "Native speaker")] + [InlineData(31, "en månad")] [InlineData(61, "2 månader")] [InlineData(92, "3 månader")] [InlineData(335, "11 månader")] @@ -68,8 +68,8 @@ public void Months(int days, string expected) } [Theory] - [Trait("Translation", "Google")] - [InlineData(366, "1 år")] + [Trait("Translation", "Native speaker")] + [InlineData(366, "ett år")] [InlineData(731, "2 år")] [InlineData(1096, "3 år")] [InlineData(4018, "11 år")] diff --git a/src/Humanizer.Tests.Shared/Localisation/zh-CN/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/zh-CN/TimeSpanHumanizeTests.cs index c76012e3b..ed9b60dd0 100644 --- a/src/Humanizer.Tests.Shared/Localisation/zh-CN/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/zh-CN/TimeSpanHumanizeTests.cs @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests { [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(366, "1 年")] [InlineData(731, "2 年")] [InlineData(1096, "3 年")] @@ -19,7 +19,7 @@ public void Years(int days, string expected) } [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(31, "1 个月")] [InlineData(61, "2 个月")] [InlineData(92, "3 个月")] diff --git a/src/Humanizer.Tests.Shared/Localisation/zh-Hans/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/zh-Hans/TimeSpanHumanizeTests.cs index d9a808886..f85c67dcb 100644 --- a/src/Humanizer.Tests.Shared/Localisation/zh-Hans/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/zh-Hans/TimeSpanHumanizeTests.cs @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests { [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(366, "1 年")] [InlineData(731, "2 年")] [InlineData(1096, "3 年")] @@ -19,7 +19,7 @@ public void Years(int days, string expected) } [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(31, "1 个月")] [InlineData(61, "2 个月")] [InlineData(92, "3 个月")] diff --git a/src/Humanizer.Tests.Shared/Localisation/zh-Hant/TimeSpanHumanizeTests.cs b/src/Humanizer.Tests.Shared/Localisation/zh-Hant/TimeSpanHumanizeTests.cs index 19f57ec6b..2bee5a24f 100644 --- a/src/Humanizer.Tests.Shared/Localisation/zh-Hant/TimeSpanHumanizeTests.cs +++ b/src/Humanizer.Tests.Shared/Localisation/zh-Hant/TimeSpanHumanizeTests.cs @@ -8,7 +8,7 @@ public class TimeSpanHumanizeTests { [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(366, "1 年")] [InlineData(731, "2 年")] [InlineData(1096, "3 年")] @@ -20,7 +20,7 @@ public void Years(int days, string expected) } [Theory] - [Trait("Translation", "Google")] + [Trait("Translation", "Native speaker")] [InlineData(31, "1 個月")] [InlineData(61, "2 個月")] [InlineData(92, "3 個月")] diff --git a/src/Humanizer/Properties/Resources.da.resx b/src/Humanizer/Properties/Resources.da.resx index fe5bfe137..7466fefb9 100644 --- a/src/Humanizer/Properties/Resources.da.resx +++ b/src/Humanizer/Properties/Resources.da.resx @@ -241,6 +241,6 @@ en måned - en år + et år \ No newline at end of file diff --git a/src/Humanizer/Properties/Resources.he.resx b/src/Humanizer/Properties/Resources.he.resx index 2848e03b4..1c9720fb7 100644 --- a/src/Humanizer/Properties/Resources.he.resx +++ b/src/Humanizer/Properties/Resources.he.resx @@ -417,7 +417,7 @@ {0} חודשים - חודשים + חודשיים {0} חודשים @@ -426,7 +426,7 @@ {0} שנים - שנים + שנתיים {0} שנים @@ -435,6 +435,6 @@ חודש - שנה אחת + שנה \ No newline at end of file diff --git a/src/Humanizer/Properties/Resources.sv.resx b/src/Humanizer/Properties/Resources.sv.resx index 976badcb7..4a0131672 100644 --- a/src/Humanizer/Properties/Resources.sv.resx +++ b/src/Humanizer/Properties/Resources.sv.resx @@ -238,9 +238,9 @@ {0} år - 1 månad + en månad - 1 år + ett år \ No newline at end of file diff --git a/src/Humanizer/TimeSpanHumanizeExtensions.cs b/src/Humanizer/TimeSpanHumanizeExtensions.cs index 17248ff46..e098c6c2f 100644 --- a/src/Humanizer/TimeSpanHumanizeExtensions.cs +++ b/src/Humanizer/TimeSpanHumanizeExtensions.cs @@ -39,7 +39,7 @@ public static string Humanize(this TimeSpan timeSpan, int precision = 1, Culture /// The maximum number of time units to return. /// Controls whether empty time units should be counted towards maximum number of time units. Leading empty time units never count. /// Culture to use. If null, current thread's UI culture is used. - /// The maximum unit of time to output. The default value is . The time units and will give approximations for time spans bigger 30 days by calculating with 365.2425 days a year and 30.4369 days a month. + /// The maximum unit of time to output. The default value is . The time units and will give approximations for time spans bigger than 30 days by calculating with 365.2425 days a year and 30.4369 days a month. /// The minimum unit of time to output. /// The separator to use when combining humanized time parts. If null, the default collection formatter for the current culture is used. ///