New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor formatters (if possible) #102

Closed

MehdiK opened this issue Mar 14, 2014 · 1 comment

Member

MehdiK commented Mar 14, 2014

Copied @waheedsayed's thought over from #70:

I'm thinking to do the following

No need for two methods to show either xxxAgo() or xxxFromNow(). One method with a flag (isFuture) is enough & method should use the proper format from resources.
No need for two methods to show either Singlexxx() or Multiplexxx(int count). Again, one method with input (with default = 1) is enough
Not sure about this yet, but I'm thinking we should also refactor the DefaultFormatter

Split it into two formatters: DateTimeFormatter & TimeSpanFormatter
Shorten names by removing prefixes DateHumaniz_xxx & TimeSpanHumanize_xxx

MehdiK mentioned this issue

Should refactor DateTime.Humanize #70

Closed

Member Author

MehdiK commented Mar 23, 2014

This was resolved in #106

MehdiK closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment