Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ByteSize for French culture #1069

Closed
rmoergeli opened this issue May 17, 2021 · 2 comments · Fixed by #1086
Closed

ByteSize for French culture #1069

rmoergeli opened this issue May 17, 2021 · 2 comments · Fixed by #1086

Comments

@rmoergeli
Copy link

Result of ByteSize.FromBytes(7404457344) is 6.9 GB. For French culture it should be 6.9 Go.

How to achieve?

English: "KB", "MB", "GB"

French: "Ko", "Mo", "Go"
@Orace
Copy link
Contributor

Orace commented Jun 9, 2021

As explained here, the it should be "Kio", "Mio", "Gio".

@Orace
Copy link
Contributor

Orace commented Jun 9, 2021

Actually fixed with 17e9884

@Orace Orace mentioned this issue Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for french culture ByteSize unit expression
2 participants
@Orace @rmoergeli