Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteSize symbols should be translated #810

Closed
jeremyVignelles opened this issue Apr 16, 2019 · 2 comments · Fixed by #1005
Closed

ByteSize symbols should be translated #810

jeremyVignelles opened this issue Apr 16, 2019 · 2 comments · Fixed by #1005

Comments

@jeremyVignelles
Copy link

Hi,
I'm French, and I'm using Humanizer to display TimeSpans and Byte size in a human readable-format.

However, in France, the term "byte" doesn't exist, except for programmers, and the word "octet" is used instead.

A few examples of english units VS french ones :

  • MB => Mo
  • kB => ko
  • kb => kb

When non-technical folks read "MB", they will read it as "Méga Bits", which is a bit different.

For reference, here is how Windows shows the file sizes:
image

@louis-z
Copy link
Contributor

louis-z commented Oct 7, 2020

I've begun implementing this... I too feel that data unit symbols should be displayed according to culture.

@louis-z
Copy link
Contributor

louis-z commented Nov 12, 2020

Just submitted an initial version. It could be simplified a bit, but I strove to limit breaking API changes... If that's not a concern, I could give it another shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants