Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Bugs Found #975

Closed
Josh-Fry opened this issue Sep 8, 2020 · 1 comment · Fixed by #982
Closed

General Bugs Found #975

Josh-Fry opened this issue Sep 8, 2020 · 1 comment · Fixed by #982

Comments

@Josh-Fry
Copy link

Josh-Fry commented Sep 8, 2020

Using the Pluralizer - Humanizer.Core v2.8.26 (Latest Release)

Input: Ex
Output: Ices

Input: Octopi
Output: Octopis

Input: Ox
Input: Oxen
Output: Oxens

Input: blank
Output: s

Input: Kale
Output: Kales
@mr-aboutin
Copy link
Contributor

mr-aboutin commented Sep 25, 2020 •
edited
Loading

Hi there, I have a couple comments on the bugs you found:

Input: Octopi
Output: Octopis

I'm not sure the Pluralize method is suposed to ignore a word that is already plural

Input: Kale
Output: Kales

Kale ca be countable and uncoutable, but it could be added in the uncountable depending on the wish of the author.

@mr-aboutin mr-aboutin mentioned this issue Sep 25, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bugs blank strings and "Ex"
2 participants
@mr-aboutin @Josh-Fry