From 194bb8f6340c7d6cfd36847fc4409999850c3ec5 Mon Sep 17 00:00:00 2001 From: Simon Cropp Date: Sat, 17 Feb 2024 00:09:53 +1100 Subject: [PATCH] remove redundant ToQuantity asserts --- src/Humanizer.Tests.Shared/ToQuantityTests.cs | 29 ++++--------------- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/src/Humanizer.Tests.Shared/ToQuantityTests.cs b/src/Humanizer.Tests.Shared/ToQuantityTests.cs index ebe31ceda..2f234a481 100644 --- a/src/Humanizer.Tests.Shared/ToQuantityTests.cs +++ b/src/Humanizer.Tests.Shared/ToQuantityTests.cs @@ -19,11 +19,8 @@ public class ToQuantityTests [InlineData("slice", 2, "2 slices")] [InlineData("slices", 1, "1 slice")] [InlineData("slices", 2, "2 slices")] - public void ToQuantity(string word, int quantity, string expected) - { + public void ToQuantity(string word, int quantity, string expected) => Assert.Equal(expected, word.ToQuantity(quantity)); - Assert.Equal(expected, word.ToQuantity((long)quantity)); - } [Theory] [InlineData("case", 0, "cases")] @@ -37,11 +34,8 @@ public void ToQuantity(string word, int quantity, string expected) [InlineData("process", 1, "process")] [InlineData("processes", 2, "processes")] [InlineData("processes", 1, "process")] - public void ToQuantityWithNoQuantity(string word, int quantity, string expected) - { + public void ToQuantityWithNoQuantity(string word, int quantity, string expected) => Assert.Equal(expected, word.ToQuantity(quantity, ShowQuantityAs.None)); - Assert.Equal(expected, word.ToQuantity((long)quantity, ShowQuantityAs.None)); - } [Theory] [InlineData("case", 0, "0 cases")] @@ -55,12 +49,8 @@ public void ToQuantityWithNoQuantity(string word, int quantity, string expected) [InlineData("process", 1, "1 process")] [InlineData("processes", 2, "2 processes")] [InlineData("processes", 1, "1 process")] - public void ToQuantityNumeric(string word, int quantity, string expected) - { - // ReSharper disable once RedundantArgumentDefaultValue - Assert.Equal(expected, word.ToQuantity(quantity, ShowQuantityAs.Numeric)); - Assert.Equal(expected, word.ToQuantity((long)quantity, ShowQuantityAs.Numeric)); - } + public void ToQuantityNumeric(string word, int quantity, string expected) => + Assert.Equal(expected, word.ToQuantity(quantity)); [Theory] [InlineData("hour", 1, "1 hour")] @@ -83,11 +73,8 @@ public void ToDoubleQuantityNumeric(string word, double quantity, string expecte [InlineData("processes", 2, "two processes")] [InlineData("processes", 1200, "one thousand two hundred processes")] [InlineData("processes", 1, "one process")] - public void ToQuantityWords(string word, int quantity, string expected) - { + public void ToQuantityWords(string word, int quantity, string expected) => Assert.Equal(expected, word.ToQuantity(quantity, ShowQuantityAs.Words)); - Assert.Equal(expected, word.ToQuantity((long)quantity, ShowQuantityAs.Words)); - } [Theory] [InlineData("case", 0, null, "0 cases")] @@ -101,11 +88,8 @@ public void ToQuantityWords(string word, int quantity, string expected) [InlineData("dollar", 1, "C0", "$1 dollar")] [InlineData("dollar", 2, "C0", "$2 dollars")] [InlineData("dollar", 2, "C2", "$2.00 dollars")] - public void ToQuantityWordsWithCurrentCultureFormatting(string word, int quantity, string format, string expected) - { + public void ToQuantityWordsWithCurrentCultureFormatting(string word, int quantity, string format, string expected) => Assert.Equal(expected, word.ToQuantity(quantity, format)); - Assert.Equal(expected, word.ToQuantity((long)quantity, format)); - } [Theory] [InlineData("case", 0, "N0", "it-IT", "0 cases")] @@ -122,7 +106,6 @@ public void ToQuantityWordsWithCustomCultureFormatting(string word, int quantity var culture = new CultureInfo(cultureCode); Assert.Equal(expected, word.ToQuantity(quantity, format, culture), GetStringComparer(culture)); - Assert.Equal(expected, word.ToQuantity((long)quantity, format, culture), GetStringComparer(culture)); } internal static StringComparer GetStringComparer(CultureInfo culture) =>