Hebrew ToWords implementation. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-line if-else statemes with braces (per Humanizer's convention)
|
Thanks for the awesome work. Merged now. Been meaning to add the dotsettings. Thanks for getting that in. |
|
I don't see that non-existing file in the project! Where was it? |
|
Never mind. Saw it. It's not listed in your changed files. Not sure how that happened! |
|
This is now on NuGet as v1.22.1. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation of ToWords in Hebrew, using both masculine and feminine forms (thanks to APIs already provided!)
In addition, some .gitignore tweaks and a team-shared .DotSettings file for ReSharper, that prevents adding if/else braces for single-lines.