Fixed "1 million" number to words in Spanish #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "1 million" in letters were wrong in Spanish. It is "un millón" not just simply "millón"
Source: http://es.wikipedia.org/wiki/Anexo:Nombres_de_los_n%C3%BAmeros_en_espa%C3%B1ol
With this PR I finish my review on NumberToLetters in Spanish.
@MehdiK @thunsaker Maybe I'll sound quite purist but we are not validating if we are processing correctly the conversion. For instance: In English the output would be wrong for numbers above (or equal than) a trillion and in Spanish the output would be wrong with numbers above (or equal than) a billion.
If we don't want to waste our time coding for big (and unusual) numbers, we should throw and exception at least.