Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for is/are #397

Closed
wants to merge 1 commit into from
Closed

Conversation

MatthewSteeples
Copy link
Contributor

I don't know whether this belongs in the same area or not, but we'd like the functionality to extend to the following kinds of sentences:

There is 1 case
There are 5 cases

We can obviously already to "case".ToQuantity(5) to get cases, but we'd like to be able to do the auxiliary verb (is/are) as well.

I've added those entries in but would be happy to get feedback on whether this is the right place or not.

@MehdiK
Copy link
Member

MehdiK commented Mar 28, 2015

Thanks @MatthewSteeples. This is alright.

P.S. I was thinking we're not too far from "There is {quantity} case".ToQuantity(5) => "There are 5 cases"

@MehdiK
Copy link
Member

MehdiK commented Mar 28, 2015

Please add your PR to the releasenotes file and leave me a comment when done and I'll merge. Thanks.

@MehdiK
Copy link
Member

MehdiK commented Mar 28, 2015

I added the release notes, rebased and pushed. Thanks.

@MehdiK MehdiK closed this Mar 28, 2015
@MehdiK
Copy link
Member

MehdiK commented Mar 29, 2015

This is now released to NuGet as v1.35.0. Thanks for the contribution.

@MatthewSteeples
Copy link
Contributor Author

@MehdiK Thanks for merging this. I'll know what to do when we've got other suggestions now. C# 6 does some interesting things with string interpolation that might make your example above a lot more attainable. I've not looked into it much yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants