-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Byte size #99
Byte size #99
Conversation
Needs: - [] Rest of tests - [] Dehumanize byte quantities - [] Refactor namespaces all around - [] Add to readme - [] Licensing
Oy. Judging by the extra changes shown, I think I may have incorrectly pulled in changes from PR #103. Should I close this one and PR against the bytesize branch? |
Do we need any other tests here? The ByteSize library is fairly well tested by itself, and the glue between the two libraries is minimal. I'd rather not have to do a whole bunch of copypasta extensions, but it seems it would be valuable to add overloads for I dropped Dehumanize Support from the todo list, I suspect it would be rare to need such functionality. What's your opinion? |
A few things went on while this PR was waiting; but you seem to have pulled them all in. So that's cool. Thanks. I haven't gone through tests TBH. We do need a few tests for Humanize methods to make sure the two connect nicely. Also the existing tests from ByteSize look very different to Humanizer ones; so they should be refactored for consistency. I think we could skip over Thanks for the great work. I will check it out later. Very busy atm. |
PR as requested, will be able to jump back in tomorrow!