fix: react-native don't support global and Document #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkang07
reviewed
Nov 25, 2024
| @@ -106,7 +106,7 @@ export function isHeaders(value: unknown): value is Headers { | |||
| } | |||
|
|
|||
| export function isDocument(value: unknown): value is Document { | |||
| return value instanceof Document; | |||
| return typeof globalThis.Document !== 'undefined' && value instanceof globalThis.Document; | |||
There was a problem hiding this comment.
理论上这个函数不应该被 rn 打包进来，这个bug 会另外修掉。
不过这里 typeof 一下也没问题
qkang07
added a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
React Native was unable to successfully integrate with the SDK due to a lack of platform compatibility code when writing the base SDK.
Link