Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Wikimedia Commons as image source #1

Open
slaporte opened this issue Aug 26, 2019 · 1 comment
Open

Include Wikimedia Commons as image source #1

slaporte opened this issue Aug 26, 2019 · 1 comment

Comments

@slaporte
Copy link

Wikimedia Commons has some beautiful, high-res Featured Pictures and a picture of the day. It would be cool if that was included as an easy image source.

@Hurtak
Copy link
Owner

Hurtak commented Aug 27, 2019

Good idea, I have put it in todos section in main README.md.
This will probably not be trivial change (not so big either) because

  1. We need to add some image provider abstraction so we do not have copy pasted code for bing, wiki, etc.
  2. I noticed that some pictures of the day are in vertical mode, so this could cause problem displaying tall images as we currently use cover image crop/display method. Maybe we could thought about some other layout, like image on the left, image description on the right, but this would need to work with existing widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants