Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorOptions - Download SVG button #10

Open
mhebrard opened this issue Nov 11, 2016 · 2 comments
Open

editorOptions - Download SVG button #10

mhebrard opened this issue Nov 11, 2016 · 2 comments

Comments

@mhebrard
Copy link
Collaborator

in the controller of a component,
if I want to hide the button 'Download SVG', I need to disable BOTH SVG and PNG
editorOptions: { data: $ctrl.dataPackage, enableSvgDownload: false, enablePngDownload: false }

If I specify only enableSvgDownload: false, the button is created.

Is it an expected behavior ?

if yes, it is a bit confusing because of the labels "svg download" <-> "download svg"
Suggestion:
1> change the button title to "download figures" that will list both options "... as SVG" and "... as PNG"
2> or create 2 distinct buttons to mirror the 2 distinct options to disable.

@Hypercubed
Copy link
Owner

Technically the buttons are supposed to represent "Download SVG as SVG" and "Download SVG as PNG". This feature will not download not SVG based figures. If the title were "Download figures" it may be just a confusing when SVG figures are not found.

@mhebrard
Copy link
Collaborator Author

hmm but (basic) user don't know that the figure are in SVG or not ... he just want to download the pict in the middle of the screen lol ...
do you have some figure not in SVG ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants