Make LuceneSearchResultsServiceImpl the primary implementation for SearchResultsService interface

[rahul6603]

Issue - #1049

Summary

• This PR aims to make LuceneSearchResultsServiceImpl the primary implementation for SearchResultsService interface and LuceneSearchResultsDAOImpl the primary implementation for SearchResultsDAO interface.
• I have also added Qualifier annotations to make it more readable about which specific implementation is being used.

[rahul6603]

fuzzy-search-demo.mov

Hi @mozzy11, could you please review the changes? I have also attached a demo video of Patient Search from the UI demonstrating fuzzy search on first name and last name.
Thanks.

[mozzy11]

Thanks @rahul6603 .
We will delay merging this PR as it depends on #1220

[rahul6603]

Hi @mozzy11, since #1220 has been merged, this PR can also be merged to finalise the Lucene integration.

[mozzy11]

Hello @rahul6603 ,
Thanks for the PR.
Can you see the QA workfow fails especially whenever theres search by patient .

[mozzy11]

Can you first ensure the Patient Serach works in the QA workflow

[rahul6603]

Hi @mozzy11 , I have made a fix in the latest commit which resolves the failing QA workflows.
I have added a check to ensure the idList parameter is only added to the SQL query when there are more than 0 hits from the Lucene query. The actual conditionif (hitsCount > 1) accounts for the dummy value (-1) in the hits list.
Let me know if any other change is needed.

[mozzy11]

Thanks @rahul6603

[mozzy11]

hello @rahul6603 ,
just to confirm , is this endpoint /reindex meant to rebuild the search index in case its broken ??
can you add a link somewhere on the admin page for a user to just click and call the endpoint to rebuild the index incase its broken ??

[rahul6603]

Hi @mozzy11, sorry for the late reply. Yeah, the endpoint /reindex is meant for rebuilding the index. Can you point me to the specific admin page where such functionality can be added?

[mozzy11]

@rahul6603 No worries.

You can add a new Side Nav Link on the Admin Page ie Search Index Management. whick links to a Search Index Management Page.

You can just put a button , for a user to click to rebuild the searxh index and it should display a loader until the Search index is completely re-build

[mozzy11]

And also , you can add more Tests for LuceneSearch for each single search Parameter to ensure nothing breaks.
The existing Lucene Search Test takes in all params supported by Lucene Search at ago

[mozzy11]

Again thanks for responding , i appreciate