Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Carbon Grid for Layout instead of Using custom css classes #1268

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Muta-Jonathan
Copy link

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Removed the inlineDiv classes to use the Grid layout Carbon react system

Screenrecord

screen-recording-2024-09-24-at-33848-pm_4UmeFNyn.mp4

Related Issue

#978

@Muta-Jonathan
Copy link
Author

cc @mozzy11

@mozzy11
Copy link
Collaborator

mozzy11 commented Oct 29, 2024

Thanks @Muta-Jonathan .
Can you resolve the few minor errors causing a CI build failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants