Skip to content

Commit

Permalink
elaborate on PRs closing issues, comments for cc
Browse files Browse the repository at this point in the history
be more specific about what writing "Fixes: #1" does, it closes the
linked issue if your PR is merged

comment commands regex can get... elaborate add a comment with an
example where it gets complex, also indicate the maintainer and curator
of the comment commands action
  • Loading branch information
casswedson committed Nov 5, 2023
1 parent 1ceae3c commit 9233237
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/comment-commands.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ trigger: specific
# TODO implement more commands, add more users
users:
active:
# maintainer
- casswedson
# curator
- Maleclypse
# voluntiers
- Termineitor244
- Faalagorn
- Ilysen
Expand Down Expand Up @@ -54,7 +57,10 @@ keywords:
value: '\/(I|i)nvalid.*'

- name: good-first-issue
# example: /good-first-issue
value: '\/(G|g)ood[\s-]*(F|f)irst[\s-]*(I|i)ssue.*'

- name: help-wanted
# - only works in PRs
# example: /help-wanted
value: '\/(H|h)elp[\s-]*(W|w)anted.*'
5 changes: 4 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/changelog.txt -->

#### Purpose of change

<!-- With a few sentences, describe your reasons for making this change. If it relates to an existing issue, you can link it with a # followed by the GitHub issue number, like #1234. If your pull request *fully* resolves an issue, include the word "Fix" or "Fixes" before the issue number, like: Fixes #xxxx
<!-- With a few sentences, describe your reasons for making this change.
If it relates to an existing issue, you can link it with a # followed by the GitHub issue number, like #1234.
When you submit a pull request that completely resolves an issue, use [Github's closing keywords](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue)
to automatically close the issue once your pull request is merged.
If there is no related issue, explain here what issue, feature, or other concern you are addressing. If this is a bugfix, include steps to reproduce the original bug, so your fix can be verified. -->

#### Describe the solution
Expand Down

0 comments on commit 9233237

Please sign in to comment.