Add public intializer to PresentationDesignable #402
Conversation
|
@mikhailmulyar Let's continue the discussion here. I changed a bit my mind, instead of putting everything public... I prefer abstract the Can you give it a try and let me know if that's ok for you? |
|
I'm even wondering if it would be worth to add a |
|
Looks like it will work. Gonna check it soon |
Generated by 🚫 danger |
|
Still not able to fully use it since those errors if i'm trying to adopt |
|
This time, it compiles! I test it to make sure it was ok 😆 |
|
Yes, now it works. Thanks! |
|
|
||
| public extension PresentationDesignable where Self: UIViewController { | ||
|
|
||
| public func configurePresenter() { |
There was a problem hiding this comment.
Great idea for having an extension method 👍
| public var modalSize: (PresentationModalSize, PresentationModalSize) = (.half, .half) | ||
| public var keyboardTranslation = ModalKeyboardTranslation.none | ||
|
|
||
| public init() {} |
There was a problem hiding this comment.
Do we need that? since it is a struct, we may omit it.
|
@mikhailmulyar The next release will include that feature, until then, you can target |
|
Ok. Thanks! |
|
Hey, @mikhailmulyar release 3.1.3 is up, you don't have to use |
Follow up of #401
Since the philosophy of
IBAnimatableis to use protocols for everything in order to reuse them in our own components, it's quite sad that we are blocking that usage forPresentationDesignable.I think we just missed that case, and it's probably an implementation error.