-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New activity indicator newtonCradle
and circlePendulum
#573
Conversation
Generated by 🚫 Danger |
fileprivate let ratio: CGFloat = 7 | ||
fileprivate let ballCount: Int = 3 | ||
|
||
#if LG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What means LG
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Life's Good
This activity indicator has been inspired from my new tv, to watch the world cup
This override the color defined and set 3 colors.
Maybe LG
could be used accidentally, If I could keep my eastern eggs, a longer compilation flag could be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we have a property instead of a custom flag? Otherwise, the user needs to set the configuration in Podfile to enable it like build_settings['OTHER_SWIFT_FLAGS'] = '-LG'
. If you think that's fun, shall we add it to ActivityIndicators.md . BTW: I have LG
big TV at home too 📺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActivityIndicatorAnimation classes are not very accessible, but I could make trueColor
as a public var
The compilation will change only the default value.
Yes I will add in doc
ps: same trick on triforce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phimage cool, thanks, LG(Life's Good), you make it even LB (Life's Better)😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The effect looks great, well done 👍 please have a look at the small comment.
fileprivate let ratio: CGFloat = 7 | ||
fileprivate let ballCount: Int = 3 | ||
|
||
#if LG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we have a property instead of a custom flag? Otherwise, the user needs to set the configuration in Podfile to enable it like build_settings['OTHER_SWIFT_FLAGS'] = '-LG'
. If you think that's fun, shall we add it to ActivityIndicators.md . BTW: I have LG
big TV at home too 📺
…e` and `circlePendulum` Use primary colors for `circlePendulum` Add doc about it
slow motion gif