Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New activity indicator newtonCradle and circlePendulum #573

Merged
merged 4 commits into from
Jul 4, 2018

Conversation

phimage
Copy link
Member

@phimage phimage commented Jun 29, 2018

newton
circlependulum
slow motion gif

@phimage phimage requested review from JakeLin and tbaranes June 29, 2018 14:41
@IBAnimatableBot
Copy link

IBAnimatableBot commented Jun 29, 2018

1 Warning
⚠️ Consider adding / updating the demo app.

Generated by 🚫 Danger

fileprivate let ratio: CGFloat = 7
fileprivate let ballCount: Int = 3

#if LG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What means LG?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Life's Good
This activity indicator has been inspired from my new tv, to watch the world cup

This override the color defined and set 3 colors.
Maybe LG could be used accidentally, If I could keep my eastern eggs, a longer compilation flag could be used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have a property instead of a custom flag? Otherwise, the user needs to set the configuration in Podfile to enable it like build_settings['OTHER_SWIFT_FLAGS'] = '-LG'. If you think that's fun, shall we add it to ActivityIndicators.md . BTW: I have LG big TV at home too 📺

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActivityIndicatorAnimation classes are not very accessible, but I could make trueColor as a public var
The compilation will change only the default value.

Yes I will add in doc

ps: same trick on triforce

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phimage cool, thanks, LG(Life's Good), you make it even LB (Life's Better)😉

Copy link
Member

@JakeLin JakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The effect looks great, well done 👍 please have a look at the small comment.

fileprivate let ratio: CGFloat = 7
fileprivate let ballCount: Int = 3

#if LG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have a property instead of a custom flag? Otherwise, the user needs to set the configuration in Podfile to enable it like build_settings['OTHER_SWIFT_FLAGS'] = '-LG'. If you think that's fun, shall we add it to ActivityIndicators.md . BTW: I have LG big TV at home too 📺

…e` and `circlePendulum`

Use primary colors for `circlePendulum`
Add doc about it
@phimage phimage merged commit eb4acb6 into master Jul 4, 2018
@JakeLin JakeLin deleted the feature/pendulum branch July 5, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants