Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swift build by adding missing import and updating package.swift #no-public-changes #623

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

phimage
Copy link
Member

@phimage phimage commented Nov 8, 2019

opening with Xcode the Package.swift file or by using command line

sdk=`xcrun -sdk iphonesimulator -show-sdk-path`
sdkVersion=`echo $sdk | sed -E 's/.*iPhoneSimulator(.*)\.sdk/\1/'`
swift build  -Xswiftc "-sdk" -Xswiftc "$sdk" -Xswiftc "-target" -Xswiftc "x86_64-apple-ios$sdkVersion-simulator"

In fact swift build do not allow missing import

I think new release must be done with that, a 6.0.1 or 6.1.0

--

Also I have added a test with github workflow, but to be activated on IBAnimatable organisation

@phimage phimage requested a review from tbaranes November 8, 2019 08:43
@phimage phimage changed the title Fix swift build by adding missing import and updating package.swift Fix swift build by adding missing import and updating package.swift #no-public-changes Nov 8, 2019
@phimage phimage requested a review from JakeLin November 8, 2019 08:44
@IBAnimatableBot
Copy link

2 Warnings
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
⚠️ Consider adding / updating the demo app.

Generated by 🚫 Danger

@tbaranes
Copy link
Member

tbaranes commented Nov 8, 2019

Thanks for this fix, I enabled GitHub Actions as you asked :)

@@ -117,6 +117,7 @@ func iterateEnum<T: Hashable>(from: T.Type) -> AnyIterator<T> {
}
#endif

import UIKit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why importing it here instead at the top of the file with the other import?

Copy link
Member Author

@phimage phimage Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking for later, moving the import and the code to its own file

And I see better fix, I will update, move it to CALayerExtension now
and move import at top for CGFloat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants