Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrected branch for mkdocs deploy. #304

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Conversation

butler54
Copy link
Collaborator

Note: Alternative techniques may be required, however, with devops integration it must be tested live.

Signed-off-by: Chris Butler chris@thebutlers.me

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Note: Alternative techniques may be required, however, with devops integration it must be tested live.

Signed-off-by: Chris Butler <chris@thebutlers.me>
@butler54 butler54 requested a review from fsuits January 17, 2021 22:17
Copy link
Contributor

@fsuits fsuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #304 (4bedb69) into develop (e77fda3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #304   +/-   ##
========================================
  Coverage    99.07%   99.07%           
========================================
  Files           50       50           
  Lines         5704     5704           
========================================
  Hits          5651     5651           
  Misses          53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77fda3...696b56f. Read the comment docs.

@butler54 butler54 merged commit 2dd5d93 into develop Jan 17, 2021
butler54 added a commit that referenced this pull request Jan 17, 2021
Note: Alternative techniques may be required, however, with devops integration it must be tested live.

Signed-off-by: Chris Butler <chris@thebutlers.me>
@butler54 butler54 deleted the fix/docs-deploy branch February 24, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants