Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lou's fix to website automation test on windows #366

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

fsuits
Copy link
Contributor

@fsuits fsuits commented Feb 18, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Lou's fix to website automation test not working on windows.

@fsuits fsuits requested review from degenaro and butler54 February 18, 2021 22:49
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #366 (a54aa63) into develop (14686a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #366   +/-   ##
========================================
  Coverage    99.11%   99.11%           
========================================
  Files           52       52           
  Lines         6472     6472           
========================================
  Hits          6415     6415           
  Misses          57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14686a8...a54aa63. Read the comment docs.

Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 merged commit 8e3ecbf into develop Feb 19, 2021
@butler54 butler54 deleted the fix/website_automation_windows branch February 24, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants