Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce oscal version in models and tests #377

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

fsuits
Copy link
Contributor

@fsuits fsuits commented Feb 25, 2021

Now enforce oscal version defined in one place. Many changes to tests and data.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Now enforce oscal version defined in one place in code. This involved modifying the base models generated along with many tests and sample data sets.

Now enforce oscal version defined in one place.  Many changes to tests and data.
@fsuits fsuits requested a review from butler54 February 25, 2021 07:51
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #377 (aa0f6ae) into develop (52a49db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #377   +/-   ##
========================================
  Coverage    98.91%   98.91%           
========================================
  Files           56       56           
  Lines         6632     6636    +4     
========================================
+ Hits          6560     6564    +4     
  Misses          72       72           
Impacted Files Coverage Δ
trestle/core/generators.py 97.26% <100.00%> (+0.11%) ⬆️
trestle/oscal/__init__.py 100.00% <100.00%> (ø)
trestle/oscal/assessment_plan.py 100.00% <100.00%> (ø)
trestle/oscal/assessment_results.py 100.00% <100.00%> (ø)
trestle/oscal/catalog.py 100.00% <100.00%> (ø)
trestle/oscal/component.py 100.00% <100.00%> (ø)
trestle/oscal/poam.py 100.00% <100.00%> (ø)
trestle/oscal/profile.py 100.00% <100.00%> (ø)
trestle/oscal/ssp.py 100.00% <100.00%> (ø)
trestle/oscal/target.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a49db...1b42ba7. Read the comment docs.

Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 merged commit 7fc08e1 into develop Feb 25, 2021
@butler54 butler54 deleted the fix/enforce_oscal_version branch February 25, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants