Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #344 check rc in tests and remove dependency on dictdiffer #440

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

fsuits
Copy link
Contributor

@fsuits fsuits commented Apr 6, 2021

Signed-off-by: FrankSuits frankst@au1.ibm.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Make sure rc in tests is checked whenever a command is run.

Also removed dependency on dictdiffer since tests were only checking for equality of dicts and not the specific differences between dicts.

…dictdiffer

Signed-off-by: FrankSuits <frankst@au1.ibm.com>
@fsuits fsuits requested a review from butler54 April 6, 2021 01:27
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #440 (2c22569) into develop (eedf171) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #440   +/-   ##
========================================
  Coverage    98.97%   98.97%           
========================================
  Files           61       61           
  Lines         7537     7537           
========================================
  Hits          7460     7460           
  Misses          77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedf171...2c22569. Read the comment docs.

Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 merged commit acc337b into develop Apr 6, 2021
@butler54 butler54 deleted the refactor/check_rc_in_tests branch April 6, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants