Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error checking and enforce 1 to 1 keys in header validation #512

Merged
merged 8 commits into from
May 13, 2021

Conversation

fsuits
Copy link
Contributor

@fsuits fsuits commented May 7, 2021

Signed-off-by: FrankSuits frankst@au1.ibm.com

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Enforce 1:1 keys in header validation
Added error checking and test for bold header in template
Changed validation text output for easier reading by user

Signed-off-by: FrankSuits <frankst@au1.ibm.com>
@fsuits fsuits requested a review from butler54 May 7, 2021 07:36
@fsuits
Copy link
Contributor Author

fsuits commented May 7, 2021

This is just to show initial progress in md and to see if my change to user output (VALID INVALID) and providing text response when validation passes are ok.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #512 (ae9b35d) into develop (b2b0db6) will decrease coverage by 0.01%.
The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #512      +/-   ##
===========================================
- Coverage    98.14%   98.12%   -0.02%     
===========================================
  Files           76       76              
  Lines         7372     7411      +39     
===========================================
+ Hits          7235     7272      +37     
- Misses         137      139       +2     
Impacted Files Coverage Δ
trestle/core/commands/md_subs/governed_docs.py 84.55% <86.95%> (+0.20%) ⬆️
trestle/core/commands/md_subs/governed_folders.py 85.82% <90.00%> (-0.44%) ⬇️
trestle/core/commands/md.py 100.00% <100.00%> (ø)
trestle/core/markdown_validator.py 94.55% <100.00%> (+0.53%) ⬆️
trestle/utils/fs.py 96.37% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b0db6...ae9b35d. Read the comment docs.

fsuits added 5 commits May 7, 2021 17:51
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
@fsuits fsuits changed the title DRAFT: added error checking and enforce 1 to 1 keys in header validation Added error checking and enforce 1 to 1 keys in header validation May 12, 2021
@fsuits
Copy link
Contributor Author

fsuits commented May 12, 2021

Added header support in gov. folders and checks for symlinks.

@fsuits fsuits marked this pull request as ready for review May 12, 2021 04:54
Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offine:

  • add functionality such that directory trees can be recursively covered by cov

@butler54 butler54 self-requested a review May 13, 2021 05:40
Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 merged commit da95862 into develop May 13, 2021
@butler54 butler54 deleted the fix/md_gov_header branch May 31, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants