-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added error checking and enforce 1 to 1 keys in header validation #512
Conversation
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
This is just to show initial progress in md and to see if my change to user output (VALID INVALID) and providing text response when validation passes are ok. |
Codecov Report
@@ Coverage Diff @@
## develop #512 +/- ##
===========================================
- Coverage 98.14% 98.12% -0.02%
===========================================
Files 76 76
Lines 7372 7411 +39
===========================================
+ Hits 7235 7272 +37
- Misses 137 139 +2
Continue to review full report at Codecov.
|
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
…nto fix/md_gov_header
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
Added header support in gov. folders and checks for symlinks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offine:
- add functionality such that directory trees can be recursively covered by cov
Signed-off-by: FrankSuits <frankst@au1.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: FrankSuits frankst@au1.ibm.com
Types of changes
Enforce 1:1 keys in header validation
Added error checking and test for bold header in template
Changed validation text output for easier reading by user