chasing after bug with DOCKER_REMOTE_IMAGE value

Signed-off-by: Maroun Touma <touma@us.ibm.com>
IBM · Nov 17, 2024 · 6631851 · 6631851
1 parent b44fff1
commit 6631851
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/transforms/.make.workflows b/transforms/.make.workflows
@@ -44,6 +44,7 @@ FORCE:
 		cd ${REPOROOT} && make -C scripts/k8s-setup setup;  \
 	fi
 ifeq ($(USE_DEV_IMAGES), 1)
+	echo ******###**** $(DOCKER_REMOTE_IMAGE)
 	cd ${TRANSFORM_SRC} && $(MAKE) image && $(MAKE) kind-load-image
 	cd ${REPOROOT}/kfp/kfp_ray_components && $(MAKE) image && $(MAKE) kind-load-image
 endif

diff --git a/transforms/language/html2parquet/kfp_ray/Makefile b/transforms/language/html2parquet/kfp_ray/Makefile
@@ -12,7 +12,6 @@ TRANSFORM_RUNTIME=ray
 ## override settings in .make.default as they assume old structure with ray being the current folder
 DOCKER_IMAGE_NAME=$(TRANSFORM_NAME)-$(TRANSFORM_RUNTIME)
 DOCKER_LOCAL_IMAGE=$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)
-DOCKER_REMOTE_IMAGE=$(DOCKER_REGISTRY_ENDPOINT)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)
 
 
 # Only build the image with -f Dockerfile.ray
@@ -50,7 +49,9 @@ workflow-build: workflow-venv
 
 .PHONY: workflow-test
 workflow-test: workflow-build
-	$(MAKE) .workflows.test-pipeline TRANSFORM_SRC=${SRC_DIR} PIPELINE_FILE=html2parquet_wf.yaml
+	$(MAKE) TRANSFORM_SRC=${SRC_DIR} \
+		DOCKER_REMOTE_IMAGE=$(DOCKER_REGISTRY_ENDPOINT)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION) \
+		PIPELINE_FILE=html2parquet_wf.yaml .workflows.test-pipeline
 
 .PHONY: workflow-upload
 workflow-upload: