Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take the references to artifactory out of README files #276

Closed
2 tasks done
shahrokhDaijavad opened this issue Jun 13, 2024 · 2 comments
Closed
2 tasks done

Take the references to artifactory out of README files #276

shahrokhDaijavad opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@shahrokhDaijavad
Copy link
Member

Search before asking

  • I searched the issues and found no similar issues.

Component

Other

Feature

A grep for the word artifactory , starting from root, found the following:

./kfp/kfp_ray_components/README.md:export ARTIFACTORY_USER=
./kfp/kfp_ray_components/README.md:export ARTIFACTORY_API_KEY=
./data-processing-lib/python/README.md:To test, build and publish the library to artifactory
./data-processing-lib/ray/README.md:To test, build and publish the library to artifactory
./data-processing-lib/spark/README.md:To test, build and publish the library to artifactory

I will fix the last 3. @roytman Can you please fix the first 2?

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@shahrokhDaijavad
Copy link
Member Author

@roytman I fixed the last 3 README files above and submitted a PR. Wasn't sure exactly what to do with the first 2 (above). Please take care of them. Thanks.

@roytman
Copy link
Member

roytman commented Jun 15, 2024

@roytman I fixed the last 3 README files above and submitted a PR. Wasn't sure exactly what to do with the first 2 (above). Please take care of them. Thanks.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants