Release process definition and implementation #297
Conversation
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
roytman
requested review from
daw3rd,
shahrokhDaijavad,
revit13,
blublinsky,
Bytes-Explorer,
Mohammad-nassar10 and
shivdeep-singh-ibm
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
|
|
||
| **Question:** should we use the same versions for release, and for shared python modules and images, such as | ||
| `DPK_LIB_VERSION`, `DPK_LIB_KFP_VERSION`, `DPK_LIB_KFP_VERSION_v2`, `DPK_LIB_KFP_SHARED`, `KFP_DOCKER_VERSION`, `KFP_DOCKER_VERSION_v2`? | ||
| If YES, maybe we can combine all these variables into a single one. |
There was a problem hiding this comment.
Does it makes sense to have 0.0.0 tag to all in dev branch and update it to the release tag upon creating a new release in the release branch (assuming their tag version is as the relase version tag)? there is no meaning to the tag version in dev as we build everything locally.
There was a problem hiding this comment.
BTW I think that the process of updating the versions in .make.versions should be done in the release branch so the .make.versions in dev branch should remain 0.0.0...
There was a problem hiding this comment.
there is no meaning to the tag version in dev as we build everything locally.
it is not exactly true, for pipeline tests on a real cluster we need relevant images.
| ## 2. Update versions | ||
| From the project root directory execute | ||
| ```shell | ||
| make versions |
There was a problem hiding this comment.
I think its make set-versions
|
|
||
| - In the [.make.versions](.make.versions) file update versions of the shared components `DPK_LIB_VERSION`, | ||
| `DPK_LIB_KFP_VERSION`, `DPK_LIB_KFP_VERSION_v2`, `DPK_LIB_KFP_SHARED`, `KFP_DOCKER_VERSION`, `KFP_DOCKER_VERSION_v2` to the desired ones | ||
| - Update transformers versions |
There was a problem hiding this comment.
Its not clear how the transforms release process is done. should it be independent of the repo release? if so, we should not update the versions in this process.
Why are these changes needed?
We need to define and after that automate the project release process.
Related issue number (if any).
#294