-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some new thoughts on cutting a release, especially scripts/release.sh #309
Merged
Changes from 33 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3dd1c9c
Some new thoughts on cutting a release, especially scripts/release.sh
daw3rd 04fb1dc
Minor updates to release.sh script
daw3rd 98a41b5
Update repo.md for 2 make users and add workflow test of global make …
daw3rd 2d006a5
Update release.sh script for testing
daw3rd cc6b3aa
more testing or release.sh script
daw3rd 4fc4f9c
More release.sh
daw3rd 8de2c49
Revert to dev versions
daw3rd e49cbaa
release.sh
daw3rd db921b9
release.sh
daw3rd 1451277
release.sh
daw3rd c276b71
release.sh
daw3rd a026584
release.sh
daw3rd 4b6f41b
release.sh
daw3rd 15317ef
release.sh
daw3rd 7d5ca76
updated repo.md on makefiles
daw3rd 679d637
Merge branch 'dev' into releasing
daw3rd c85c68a
add publish target to superworkflows Makefile
daw3rd 2a7bcb9
More release work
daw3rd 12f315b
add publish target to kind/Makefile
daw3rd 6c0d4ab
install ../python for spark transforms in .make.defaults
daw3rd f6bd444
fix kfp set versions, and noop versions
daw3rd 103f559
Fix versioning in .make* and typo in noop/ray/pyproject.tmo
daw3rd 7b3be84
Merge branch 'dev' into releasing
daw3rd 7f7a264
comments and dont created empty pyproject.toml in .make.defaults
daw3rd 52e4eb7
update release.sh to apply final version changes
daw3rd 6211b50
Version updates, version setting fixes, noop spark Dockerfile,
daw3rd af8ce1c
Merge branch 'dev' into releasing
daw3rd 51fe74c
set-versions inputcode2parquet'
daw3rd 3db00f7
restore INGEST_TO_PARQUET_VERSION removed in recent commit"
daw3rd caa42b4
updated repo.md to point to include link to transform conventions
daw3rd b43683f
fix transform link added to repo.md in last commit
daw3rd fcc6136
Merge branch 'dev' into releasing
daw3rd 67d3357
fixed code2parquet versions from last merge and uninstall libs in bet…
daw3rd 37a24d0
Merge branch 'dev' into releasing
daw3rd 40ccc4c
remove redundant pip uninstall in .make.defaults
daw3rd 0123b7e
Fix transform version settings when python transform code is referenced
daw3rd 87a7549
.make.versions changes - remove redancy and unused macros, and define…
daw3rd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -132,3 +132,4 @@ | |
"hash": null | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Release Management | ||
|
||
Release are created from the main repository branch using the version | ||
numbers, including an intermediate version suffix, | ||
defined in `.make.versions`. | ||
The following points are important: | ||
|
||
1. `.make.versions` contains the version to be used when publishing the **next** release. | ||
1. The main branch always has the version suffix set to .dev<N>, which | ||
allows intermediate publishing from the dev branch using version X.Y.Z.dev<N>. | ||
2. In general, common version number is used for all published pypi wheels and docker images. | ||
3. The `scripts/release.sh` script automates the following: | ||
1. Creating a `release/vX.Y.Z` branch and `vX.Y.Z` tag | ||
2. Nulling out the version suffix in the new branch's `.make.version` file. | ||
3. Applying the unsuffixed versions to the artifacts published from the repo. | ||
4. Building and publishing the wheels to pypi and images to a docker registry. | ||
5. Incrementing the minor version and resetting the suffix in the main branch. | ||
|
||
# Cutting the release | ||
Creating the release requires running the `release.sh` script and optionally | ||
generating a release on github. The latter can be performed manually | ||
once the `release.sh` script has done its work. | ||
|
||
## release.sh | ||
Running `release.sh` requires credentials to publish to the various cloud locations. | ||
|
||
For docker registry publishing, the following environment variables/credentials are needed: | ||
|
||
* DPK_DOCKER_REGISTRY_USER - user used with the registry defined in DOCKER_HOST in `.make.defaults` | ||
* DPK_DOCKER_REGISTRY_KEY - key/password for docker registry user. | ||
|
||
To publish to pypi, the credentials in `~/.pypirc` file (let us know if there is a way to do | ||
this with environment variables). | ||
See [pypi](https://packaging.python.org/en/latest/specifications/pypirc/) for details. | ||
|
||
To see the version that will be published, | ||
``` | ||
make DPK_VERSION_SUFFIX= show-version | ||
``` | ||
This will print for example, 1.2.3. | ||
|
||
To generate the release : | ||
```shell | ||
bash scripts/release.sh | ||
``` | ||
|
||
## Github release | ||
After running the `release.sh` script, to create tag `vX.Y.Z` and branch `releases/vX.Y.Z` | ||
1. Go to the [releases page](https://github.com/IBM/data-prep-kit/releases). | ||
2. Select `Draft a new release` | ||
3. Select `Choose a tag -> vX.Y.Z` | ||
4. Press `Generate release notes` | ||
5. Add a title (e.g., Release X.Y.Z) | ||
6. Add any additional relese notes. | ||
7. Press `Publish release` | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears twice.