Fix kfp pipelines testing in github workflow. #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw3rd
requested changes
Sep 23, 2024
There was a problem hiding this comment.
why is this file being added? I don't see the code/inputcode2parquet transform in dev
daw3rd
requested changes
Sep 23, 2024
revit13
force-pushed
the
kfp17
branch
3 times, most recently
from
9f8eb4b to
429d1b3
Compare
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
revit13
force-pushed
the
kfp17
branch
2 times, most recently
from
3879aa1 to
b7e5d0d
Compare
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
roytman
reviewed
Sep 26, 2024
daw3rd
requested changes
Sep 27, 2024
| - "releases/**" | ||
| paths: | ||
| - "@TARGET_TRANSFORM_DIR@/**" | ||
| - "!data-processing-lib/**" # This is tested in separate workflow |
There was a problem hiding this comment.
I don't believe. you needs this NOTs on data-processing-lib or kfp
| - "!kfp/**.md" | ||
| - "!kfp/**/doc/**" | ||
| - "data-processing-lib/**" | ||
| - "!data-processing-lib/**/test/**" |
There was a problem hiding this comment.
Should not need this NOTs on data-processing-lib
There was a problem hiding this comment.
oops my bad. I did not see the inclusion on data-processing-lib/**
daw3rd
reviewed
Sep 27, 2024
.github/workflows/README.md
Outdated
| 3. When the shared kfp components changes, test a randomly selected transform test | ||
| (We would like to avoid running all transform kfp tests in one PR) | ||
| 3. When the shared kfp components changes or core dpk lib components files changes, | ||
| test a randomly selected transform test. Otherwise run kfp test for the changed transforms. | ||
| 4. Extra credit: If .md or other non-code changes are made, run no tests. |
There was a problem hiding this comment.
i think this number 4 can be removed.
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
daw3rd
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix kfp pipelines testing in github workflow.