Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay before deleting ray cluster in kfp component. #612

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

revit13
Copy link
Collaborator

@revit13 revit13 commented Sep 22, 2024

Why are these changes needed?

For debugging purposes add delay before deleting ray cluster in kfp component.

Signed-off-by: Revital Sur <eres@il.ibm.com>
@revit13 revit13 marked this pull request as draft September 22, 2024 12:21
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
@blublinsky
Copy link
Collaborator

I am not sure we need this. We already have delay in execution

Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
@revit13 revit13 requested a review from roytman September 23, 2024 06:26
@revit13 revit13 marked this pull request as ready for review September 23, 2024 06:26
@roytman
Copy link
Member

roytman commented Sep 23, 2024

I am not sure we need this. We already have a delay in execution

Hi @blublinsky , it is a different delay, if somebody wants to debug the Ray cluster, this delay will allow it before destroying the Ray cluster.

@blublinsky
Copy link
Collaborator

I am not sure we need this. We already have a delay in execution

Hi @blublinsky , it is a different delay, if somebody wants to debug the Ray cluster, this delay will allow it before destroying the Ray cluster.

Oh, then yes. It was not clear. sorry

Copy link
Member

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roytman roytman merged commit 2b0c7a7 into IBM:dev Sep 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants