Update to exception processing doc #614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wood <dawood@us.ibm.com>
Signed-off-by: David Wood <dawood@us.ibm.com>
Signed-off-by: David Wood <dawood@us.ibm.com>
blublinsky
requested changes
Sep 23, 2024
| the transform should either | ||
| * throw any exception in `__init__()`, or | ||
| * throw an UnrecoverableException from AbstractBinaryTransform's `transform_binary`, `flush_binary(), or |
There was a problem hiding this comment.
throwing any exception in __init__() will not terminate the process. It will just continue re creating an actor
There was a problem hiding this comment.
so what happens, effectively, to the actor and the processing of data when init() throws an exception. I would presume that no data is processed by an actor that gets an exception in init(),and since all actors likely get the same exception, all data processing is ended?
There was a problem hiding this comment.
Added more precise doc in #616
Signed-off-by: David Wood <dawood@us.ibm.com>
|
This was done in PR #616 |
|
commited additional .md changes, so re-opening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
clarity
Related issue number (if any).