Skip to content

Commit

Permalink
fix(url): fix the sdk url for semantic and minor updates
Browse files Browse the repository at this point in the history
  • Loading branch information
ehdsouza committed Mar 21, 2019
1 parent 0426ecd commit 54e75fe
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ script:
deploy:
- provider: script
skip_cleanup: true
script: npx semantic-release --repository-url https://${GH_TOKEN}@github.com/watson-developer-cloud/go-sdk
script: npx semantic-release --repository-url https://${GH_TOKEN}@github.com/IBM/go-sdk-core
--debug
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,6 @@ By making a contribution to this project, I certify that:
+ [General GitHub documentation](https://help.github.com/)
+ [GitHub pull request documentation](https://help.github.com/send-pull-requests/)

[dw]: https://developer.ibm.com/answers/questions/ask/?topics=watson
[stackoverflow]: http://stackoverflow.com/questions/ask?tags=ibm-watson
[dw]: https://developer.ibm.com/answers/questions/ask.html
[stackoverflow]: http://stackoverflow.com/questions/ask?tags=ibm
[dep]: https://github.com/golang/dep
4 changes: 2 additions & 2 deletions core/base_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ type ServiceOptions struct {
IAMURL string
}

// WatsonService Base Service
// BaseService Base Service
type BaseService struct {
Options *ServiceOptions
DefaultHeaders http.Header
Expand All @@ -66,7 +66,7 @@ type BaseService struct {
UserAgent string
}

// NewBaseService Instantiate a Watson Service
// NewBaseService Instantiate a Base Service
func NewBaseService(options *ServiceOptions, serviceName, displayName string) (*BaseService, error) {
if HasBadFirstOrLastChar(options.URL) {
return nil, fmt.Errorf("The URL shouldn't start or end with curly brackets or quotes. Be sure to remove any {} and \" characters surrounding your URL")
Expand Down
2 changes: 1 addition & 1 deletion core/detailed_response.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"net/http"
)

// DetailedResponse : Generic response for Watson API
// DetailedResponse : Generic response for IBM API
type DetailedResponse struct {
StatusCode int // HTTP status code
Headers http.Header // HTTP response headers
Expand Down

0 comments on commit 54e75fe

Please sign in to comment.