Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goroutine leak core.IamAuthenticator #108

Closed
alexsniffin opened this issue Apr 20, 2021 · 2 comments · Fixed by #109
Closed

goroutine leak core.IamAuthenticator #108

alexsniffin opened this issue Apr 20, 2021 · 2 comments · Fixed by #109
Assignees
@pyrooka
Labels
released

Comments

@alexsniffin
Copy link

alexsniffin commented Apr 20, 2021 •
edited
Loading

There appears to be a goroutine leak happening in iam_authenticator.go.

The function is spawning a goroutine which will then idle on the sending to the channel if the main goroutine executes the select statement before authenticator.invokeRequestTokenData() returns. The problem is default on L225 will exit the select statements scope before receiving the new token.

Profile:
leak.pdf
@padamstx
Copy link
Member

@pyrooka Could you please take a look at this issue?

@pyrooka pyrooka mentioned this issue Apr 21, 2021
Merged
@ibm-devx-sdk
Copy link

🎉 This issue has been resolved in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyrooka pyrooka

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: eliminate goroutine leak in the authenticators IBM/go-sdk-core
4 participants
@alexsniffin @pyrooka @padamstx @ibm-devx-sdk