-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constructServiceURL
function
#119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but I suggested a few improvements.
From the [Go docs](https://blog.golang.org/maps): > A nil map behaves like an empty map when reading.
It won't be much of a speed difference since we're dealing with a small number of variables.
…e into support_parameterized_url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [5.5.0](v5.4.5...v5.5.0) (2021-06-02) ### Features * add `constructServiceURL` function ([#119](#119)) ([8213faa](8213faa))
🎉 This PR is included in version 5.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [5.5.0](v5.4.5...v5.5.0) (2021-06-02) ### Features * add `constructServiceURL` function ([#119](#119)) ([8213faa](8213faa))
This function can be used by an API to construct a service URL from a parameterized URL.