chore: set the minimum TLS version in the client to v1.2 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Looks good!
Just need to perhaps add an extra test for a retryable client.
Edit: oh and one more thing... this commit should probably have a "feat" type prefix so we get a new minor version.
Edit 2: I think we need to also test these changes with a couple of integration tests within the platform-services go SDK just to make sure that these changes work correctly with some actual IBM Cloud services.
ricellis
approved these changes
Mar 11, 2022
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 16, 2022
## [5.9.3](v5.9.2...v5.9.3) (2022-03-16) ### Bug Fixes * set the minimum TLS version in the client to v1.2 ([#156](#156)) ([0188990](0188990))
|
🎉 This PR is included in version 5.9.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the client in the base service to require
at least TLS v1.2 for secure communication with the server.