fix: retain http.Client config when retries are enabled #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
commented
Mar 17, 2022
| @@ -273,41 +300,9 @@ func (service *BaseService) IsSSLDisabled() bool { | |||
| return false | |||
| } | |||
|
|
|||
| // getClientTransportForSSL() will return the http.Transport instance | |||
padamstx
commented
Mar 17, 2022
| // setMinimumTLSVersion sets the minimum TLS version required by the client to TLS v1.2 | ||
| func setMinimumTLSVersion(client *http.Client) { | ||
| tr := getClientTransportForSSL(client) | ||
| if tr != nil { | ||
| if tr, ok := client.Transport.(*http.Transport); tr != nil && ok { |
There was a problem hiding this comment.
we will now only call this method on an actual (non-retryable) http.Client instance
pyrooka
approved these changes
Mar 21, 2022
This commit includes changes to the BaseService functionality so that enabling automatic retries will not cause the loss of any existing http.Client instance that might be set on the BaseService. A user can now use BaseService.SetHTTPClient() to set a custom client instance with or without retries being enabled. Also, the BaseService.GetHTTPClient() method was introduced which will return the correct http.Client instance regardless of whether retries are enabled or not.
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 22, 2022
## [5.9.4](v5.9.3...v5.9.4) (2022-03-22) ### Bug Fixes * retain http.Client config when retries are enabled ([#157](#157)) ([fe093da](fe093da))
|
🎉 This PR is included in version 5.9.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes changes to the BaseService functionality
so that enabling automatic retries will not cause the loss of
any existing http.Client instance that might be set on the
BaseService.
A user can now use BaseService.SetHTTPClient() to set
a custom client instance with or without retries being enabled.
Also, the BaseService.GetHTTPClient() method was introduced
which will return the correct http.Client instance regardless
of whether retries are enabled or not.