Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IamAssumeAuthenticator): introduce new authenticator type #229

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

padamstx
Copy link
Member

This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux.

@padamstx padamstx self-assigned this Sep 27, 2024
@padamstx padamstx force-pushed the iam-assume branch 2 times, most recently from 7ed4e49 to c716644 Compare September 27, 2024 18:54
@padamstx
Copy link
Member Author

padamstx commented Sep 27, 2024

@michaelbeck Michael, this PR contains the new authenticator that uses the "assume" grant type. If you have a chance, I'd appreciate any feedback you might have, especially on the documentation changes in the Authentication.md file. Thanks!

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me! 👍

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the embedded IAM Authenticator approach, just like the extensive unit testing.

Authentication.md Outdated Show resolved Hide resolved
core/iam_assume_authenticator.go Outdated Show resolved Hide resolved
This commit introduces the new IamAssumeAuthenticator which
will fetch an IAM access token using the IAM getToken operation's
"assume" grant type.  The resulting access token allows the
application to assume the identity of a trusted profile,
similar to the "sudo" feature of Linux.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx
Copy link
Member Author

padamstx commented Oct 9, 2024

I've updated the PR with changes that make an IamAssumeAuthenticator instance immutable after construction. The changes are in a second commit, so it should be easy to see the differences.

@padamstx
Copy link
Member Author

Re-requested reviews mainly to just look over the new changes (second commit).

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good!

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit df85f15 into main Oct 15, 2024
4 checks passed
@padamstx padamstx deleted the iam-assume branch October 15, 2024 14:12
ibm-devx-sdk pushed a commit that referenced this pull request Oct 15, 2024
# [5.18.0](v5.17.5...v5.18.0) (2024-10-15)

### Features

* **IamAssumeAuthenticator:** introduce new authenticator type ([#229](#229)) ([df85f15](df85f15))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants