-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IamAssumeAuthenticator): introduce new authenticator type #229
Conversation
7ed4e49
to
c716644
Compare
@michaelbeck Michael, this PR contains the new authenticator that uses the "assume" grant type. If you have a chance, I'd appreciate any feedback you might have, especially on the documentation changes in the Authentication.md file. Thanks! |
c716644
to
96fac2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good to me! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the embedded IAM Authenticator approach, just like the extensive unit testing.
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
I've updated the PR with changes that make an IamAssumeAuthenticator instance immutable after construction. The changes are in a second commit, so it should be easy to see the differences. |
Re-requested reviews mainly to just look over the new changes (second commit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# [5.18.0](v5.17.5...v5.18.0) (2024-10-15) ### Features * **IamAssumeAuthenticator:** introduce new authenticator type ([#229](#229)) ([df85f15](df85f15))
🎉 This PR is included in version 5.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux.