New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change function args from zap.Logger to interface{} #14

Open

depohmel opened this issue Nov 18, 2018 · 1 comment

Assignees

Contributor

depohmel commented Nov 18, 2018

Right now lib is forcing a user to use zap logger. It would be better to allow a user to have a choice.

Example:

ibmcloud-storage-volume-lib/provider/utils/init_provider.go

Line 28 in 2218e46

    
           func InitProviders(conf *config.Config, logger *zap.Logger) (registry.Providers, error) {

akgunjal assigned arahamad-zz

Member

arahamad-zz commented Nov 20, 2018

good suggestion, we will fix it as an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment