fix: set visibility of ConfigBasedAuthenticatorFactory.createAuthenticator to protected #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cator to protected This commit changes the visibility of the "ConfigBasedAuthenticatorFactory.createAuthenticator()" method from private to protected to allow SDKs to override this class in order to support alternate configuration sources (e.g. injected spring properties).
padamstx
commented
Feb 18, 2022
src/test/java/com/ibm/cloud/sdk/core/test/security/BasicAuthenticatorTest.java
Show resolved
Hide resolved
padamstx
commented
Feb 18, 2022
src/test/java/com/ibm/cloud/sdk/core/test/security/ConfigBasedAuthenticatorFactoryTest.java
Show resolved
Hide resolved
tomblench
approved these changes
Feb 21, 2022
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Feb 21, 2022
## [9.15.4](9.15.3...9.15.4) (2022-02-21) ### Bug Fixes * set visibility of ConfigBasedAuthenticatorFactory.createAuthenticator to protected ([#165](#165)) ([ef1ef9a](ef1ef9a))
|
🎉 This PR is included in version 9.15.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the visibility of the
"ConfigBasedAuthenticatorFactory.createAuthenticator()" method from
private to protected to allow SDKs to override this class
in order to support alternate configuration sources
(e.g. injected spring properties).