Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model: New FilterPatternUnion #9

Open
gflima opened this issue Jan 16, 2024 · 2 comments
Open

Model: New FilterPatternUnion #9

gflima opened this issue Jan 16, 2024 · 2 comments
Assignees
@gflima
Labels
enhancement New feature or request
Milestone
0.4 release

Comments

@gflima
Copy link
Collaborator

gflima commented Jan 16, 2024

Update the FilterPattern class hierarchy to:

  • FilterPattern (abstract)
    • BasicFilterPattern or StatementPattern (the current implementation)
    • UnionFilterPattern (union of 2 or more filter patterns)

Implementation of UnionFilterPattern:

  1. If no snak sets occur in the child patterns, then each child pattern becomes an entry in the VALUES clause of filter.
  2. Otherwise, each child pattern becomes a separate call to filter() and these calls are merged by the union.
@gflima gflima added the enhancement New feature or request label Jan 16, 2024
@gflima gflima self-assigned this Jan 16, 2024
@gflima gflima added this to the 0.4 release milestone Feb 7, 2024
@gflima
Copy link
Collaborator Author

gflima commented Feb 7, 2024

See #24

@gflima
Copy link
Collaborator Author

gflima commented Apr 22, 2024

Superseded by the pattern API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gflima gflima

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4 release
Development

No branches or pull requests
1 participant
@gflima