Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use kui's editor for kubectl edit #4388

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Apr 29, 2020

Fixes #762

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #4388 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4388      +/-   ##
==========================================
+ Coverage   58.81%   58.89%   +0.08%     
==========================================
  Files          75       75              
  Lines        2411     2411              
  Branches      582      582              
==========================================
+ Hits         1418     1420       +2     
+ Misses        767      763       -4     
- Partials      226      228       +2     
Impacted Files Coverage Δ
packages/core/src/core/command-tree.ts 70.43% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8a97d...a93d34f. Read the comment docs.

@starpit starpit changed the title Fix 762 feat: use kui's editor for kubectl edit Apr 29, 2020
@starpit starpit force-pushed the fix-762 branch 5 times, most recently from 8a6ead3 to 1991655 Compare April 29, 2020 13:38
@starpit starpit merged commit 414e813 into kubernetes-sigs:master Apr 29, 2020
@starpit starpit deleted the fix-762 branch April 29, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using kui for KUBE_EDITOR and GIT_EDITOR
1 participant