Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-bash-like): small visual glitch in PTY, blocks odd… #4407

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Apr 29, 2020

…ly shift sometimes

Fixes #4406

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #4407 into master will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4407      +/-   ##
==========================================
+ Coverage   58.89%   59.10%   +0.20%     
==========================================
  Files          75       75              
  Lines        2411     2411              
  Branches      582      582              
==========================================
+ Hits         1420     1425       +5     
+ Misses        763      759       -4     
+ Partials      228      227       -1     
Impacted Files Coverage Δ
packages/core/src/core/userdata.ts 68.05% <0.00%> (+4.16%) ⬆️
packages/core/src/repl/tab-completion.ts 86.66% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86458c...3968ada. Read the comment docs.

@starpit starpit merged commit bb2119e into kubernetes-sigs:master Apr 29, 2020
@starpit starpit deleted the fix-4406 branch April 29, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small visual glitch regression in pty: blocks oddly shift
1 participant