Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-bash-like): PTY performance tweaks by removing !im… #4413

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Apr 30, 2020

…portant css

also optimize closing of vi

Fixes #4412

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #4413 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4413      +/-   ##
==========================================
- Coverage   58.89%   58.81%   -0.09%     
==========================================
  Files          75       75              
  Lines        2411     2411              
  Branches      582      582              
==========================================
- Hits         1420     1418       -2     
- Misses        763      767       +4     
+ Partials      228      226       -2     
Impacted Files Coverage Δ
packages/core/src/core/command-tree.ts 69.56% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2119e...f9b397b. Read the comment docs.

@starpit starpit merged commit 3e1f8e7 into kubernetes-sigs:master Apr 30, 2020
@starpit starpit deleted the fix-4412 branch April 30, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xterm.css has lots of !important and character-level !important
1 participant