Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-kubectl): k get pods --all-namespaces has a title with "default" as the namespace #4482

Merged
merged 1 commit into from
May 6, 2020

Conversation

myan9
Copy link
Contributor

@myan9 myan9 commented May 6, 2020

Fixes #4466

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@myan9 myan9 requested a review from starpit as a code owner May 6, 2020 14:17
Copy link
Contributor

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4482 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4482      +/-   ##
==========================================
+ Coverage   59.04%   59.12%   +0.08%     
==========================================
  Files          75       75              
  Lines        2410     2410              
  Branches      582      582              
==========================================
+ Hits         1423     1425       +2     
+ Misses        762      760       -2     
  Partials      225      225              
Impacted Files Coverage Δ
packages/core/src/util/i18n.ts 64.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f4a99...b0a6d8d. Read the comment docs.

@starpit starpit merged commit 2f95129 into kubernetes-sigs:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k get pods --all-namespaces has a title with "default" as the namespace
2 participants