fix(plugins/plugin-bash-like): fix url regex #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current regex `:(\d+)?` will fail to parse urls without port (e.g. http://kui.io/...) also, the way of generating url may have problem. if current href is `https://kui.io/kui?query...`, after replace, the ending part will still be there, so url will be `https://kui.io/kui?query.../bash/...` instead of `https://kui.io/bash/...`. if server returns a path start from `/`, shouldn't it to be directly append after host?
Codecov Report
@@ Coverage Diff @@
## master #4501 +/- ##
=======================================
Coverage 59.04% 59.04%
=======================================
Files 75 75
Lines 2410 2410
Branches 582 582
=======================================
Hits 1423 1423
Misses 762 762
Partials 225 225 Continue to review full report at Codecov.
|
starpit
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current regex
:(\d+)?will fail to parse urls without port (e.g. http://kui.io/...)also, the way of generating url may have problem. if current href is
https://kui.io/kui?query..., after replace, the ending part will still be there, so url will behttps://kui.io/kui?query.../bash/...instead ofhttps://kui.io/bash/....if server returns a path start from
/, shouldn't it to be directly append after host?Description of what you did:
Fix bash-like client url regex
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs