fix: clicking on container name in details sidecar should add -c to logs command #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogs command Also delegates oc logs to kubectl Fixes kubernetes-sigs#4498
myan9
added
8_7_x
Codecov Report
@@ Coverage Diff @@
## master #4559 +/- ##
=======================================
Coverage 59.13% 59.13%
=======================================
Files 77 77
Lines 2430 2430
Branches 593 593
=======================================
Hits 1437 1437
Misses 764 764
Partials 229 229 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also delegates oc logs to kubectl
Fixes #4498
Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs