Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Quitting IBM Notifier returns 0 or main button pressed #138

Closed
rrhiralal opened this issue Nov 8, 2022 · 3 comments · Fixed by #167
Closed

[BUG] Quitting IBM Notifier returns 0 or main button pressed #138

rrhiralal opened this issue Nov 8, 2022 · 3 comments · Fixed by #167
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rrhiralal
Copy link

Describe the bug
Quitting IBM Notifier, either via CMD+Q or via activity monitor, returns 0 or main button pressed

To Reproduce
Steps to reproduce the behavior:
Run IBM notifier from terminal, hit cmd+Q or quit via activity monitor
Monitor output, it will return 0

Expected behavior
An action like this should return something other than a success. Ideally an error with a unique error code corresponding to that action.

Additionally, it would be good to have the ability to configure settings to allow or block the ability to use cmd+Q. From an admin perspective, this would be helpful and avoid users skirting policies that rely on the notifier prompts

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: macOS 13
  • Project version: 2.9.1

Additional context
Add any other context about the problem here.

@rrhiralal rrhiralal added the bug Something isn't working label Nov 8, 2022
@SMartorelli SMartorelli self-assigned this Nov 9, 2022
@SMartorelli SMartorelli added this to the Version 3.0.0 milestone Nov 9, 2022
@marcusheBG
Copy link

Hi 2nd'ing the request to block command Q

We tried adding custom System Preferences Keyboard app shortcuts for "Quit" and "Quit IBM Notifier" (which can also be done command line) but no success.

Thank you so much.

@porkcharsui
Copy link

porkcharsui commented Feb 3, 2023

Rather than blocking the COMMAND + Q shortcut in IBM Notifier, using non-zero return code that denotes the notification was terminated would suffice.

Today's behavior of exit code 0 for quit events AND main button presses makes it impossible for the calling script to understand what actually occurred!

@SMartorelli
Copy link
Member

Yes @porkcharsui the plan for this issue is to return the code "239: User dismissed the popup/banner/onboarding UI" instead of 0 when CMD+Q shortcut is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants