Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IamAssumeAuthenticator): add new authentication type for iam assume #287

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Oct 4, 2024

This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux.

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

@dpopp07 dpopp07 requested review from padamstx and pyrooka October 4, 2024 17:23
@dpopp07 dpopp07 force-pushed the dp/iam-assume-auth branch from f6ede06 to 3f614fc Compare October 4, 2024 20:14
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few minor things to fix before merging.

auth/authenticators/iam-assume-authenticator.ts Outdated Show resolved Hide resolved
Authentication.md Show resolved Hide resolved
Authentication.md Outdated Show resolved Hide resolved
Authentication.md Outdated Show resolved Hide resolved
@dpopp07 dpopp07 force-pushed the dp/iam-assume-auth branch from a32df50 to 279f1e5 Compare October 7, 2024 18:33
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I found one small typo, and also added a comment about the refreshToken, which we're not intending to support... or at least we do not yet support it in the Go and Java implementations.

test/unit/iam-assume-authenticator.test.js Outdated Show resolved Hide resolved
test/unit/iam-assume-authenticator.test.js Outdated Show resolved Hide resolved
@dpopp07 dpopp07 force-pushed the dp/iam-assume-auth branch from 20ef8ea to ff8f4a0 Compare October 8, 2024 20:39
package.json Show resolved Hide resolved
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good! :)

@dpopp07 dpopp07 force-pushed the dp/iam-assume-auth branch from 201b085 to 766562b Compare October 10, 2024 20:59
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good.

dpopp07 and others added 2 commits October 11, 2024 10:36
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM
access token using the IAM getToken operation's "assume" grant type. The
resulting access token allows the application to assume the identity of a
trusted profile, similar to the "sudo" feature of Linux.

Signed-off-by: Dustin Popp <dustinpopp@ibm.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Dustin Popp <dustinpopp@ibm.com>
@dpopp07 dpopp07 force-pushed the dp/iam-assume-auth branch from 766562b to 61185a2 Compare October 11, 2024 15:37
@pyrooka pyrooka merged commit addebfc into main Oct 15, 2024
3 checks passed
@pyrooka pyrooka deleted the dp/iam-assume-auth branch October 15, 2024 14:15
ibm-devx-sdk pushed a commit that referenced this pull request Oct 15, 2024
# [5.1.0](v5.0.2...v5.1.0) (2024-10-15)

### Features

* **IamAssumeAuthenticator:** add new authentication type for iam assume ([#287](#287)) ([addebfc](addebfc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants