-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IamAssumeAuthenticator): add new authentication type for iam assume #287
Conversation
f6ede06
to
3f614fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only a few minor things to fix before merging.
a32df50
to
279f1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I found one small typo, and also added a comment about the refreshToken, which we're not intending to support... or at least we do not yet support it in the Go and Java implementations.
20ef8ea
to
ff8f4a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good! :)
201b085
to
766562b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good.
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux. Signed-off-by: Dustin Popp <dustinpopp@ibm.com> Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com> Co-authored-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Dustin Popp <dustinpopp@ibm.com>
766562b
to
61185a2
Compare
# [5.1.0](v5.0.2...v5.1.0) (2024-10-15) ### Features * **IamAssumeAuthenticator:** add new authentication type for iam assume ([#287](#287)) ([addebfc](addebfc))
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This commit introduces the new IamAssumeAuthenticator which will fetch an IAM access token using the IAM getToken operation's "assume" grant type. The resulting access token allows the application to assume the identity of a trusted profile, similar to the "sudo" feature of Linux.
Checklist
npm test
passes (tip:npm run lint-fix
can correct most style issues)