fix: do not crash when operation has illegal $ref, print error instead #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add hasRefProperty utility module, refactor some logic to use it
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 92.04% 92.09% +0.04%
==========================================
Files 52 53 +1
Lines 1873 1884 +11
==========================================
+ Hits 1724 1735 +11
Misses 149 149
Continue to review full report at Codecov.
|
mkistler
reviewed
Aug 28, 2019
|
|
||
| module.exports.validate = function({ resolvedSpec, isOAS3 }, config) { | ||
| module.exports.validate = function({ jsSpec, resolvedSpec, isOAS3 }, config) { |
There was a problem hiding this comment.
Of course! I always thought of validators as operating on either the jsSpec or resolvedSpec, but no reason you can't use both. Nice!
dpopp07
pushed a commit
that referenced
this pull request
Aug 28, 2019
## [0.13.5](v0.13.4...v0.13.5) (2019-08-28) ### Bug Fixes * do not crash when operation has illegal $ref, print error instead ([#103](#103)) ([3d34205](3d34205))
|
🎉 This PR is included in version 0.13.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the validator will crash if an operation is illegally defined by a $ref. This PR addresses that issue and also prints a warning for an illegal $ref in an operation.
I also added a module to check for $refs when working with the resolved spec as it was needed in a couple of places.
Todo:
Resolves #100